Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Fix Travis CI PRs builds and add copyrights #52

Merged
merged 5 commits into from
May 2, 2018
Merged

Conversation

dluc
Copy link
Member

@dluc dluc commented Apr 28, 2018

Change type

  • Bug fix
  • New feature
  • Enhancement
  • Breaking change (breaks backward compatibility)

Checklist:

  • All tests passed
  • The code follows the code style and conventions of this project
  • The change requires a change to the documentation
  • I have updated the documentation accordingly

Description and Motivation

Small fix to support external PRs


This change is Reviewable

@dluc dluc self-assigned this Apr 28, 2018
@dluc dluc requested a review from a team April 28, 2018 00:49
if [[ "$TRAVIS_SECURE_ENV_VARS" == "false" ]]; then
echo "Info: skipping env vars check during Travis CI build"
exit 0
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we need to this for all the repos?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like several other repos also need the update.

Copy link

@ap-git-hub ap-git-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

if [[ "$TRAVIS_SECURE_ENV_VARS" == "false" ]]; then
echo "Info: skipping env vars check during Travis CI build"
exit 0
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like several other repos also need the update.

@ppathan ppathan merged commit ec2a9bc into master May 2, 2018
@ppathan ppathan deleted the 2018-04-27-shebang branch August 17, 2018 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants