Remove unused variable storage_os_disk_size_gb

[lonegunmanb]

Is there an existing issue for this?

• I have searched the existing issues

Description

var.storage_os_disk_size_gb is an unused variable so we should remove it, but removing an exist variable is a breaking change, so we should leave it to a major upgrade.

New or Affected Resource(s)/Data Source(s)

var.storage_os_disk_size_gb

Potential Terraform Configuration

No response

References

No response

[azureterraformbot]

Thanks for opening this issue!

[yatzek]

This variable was introduced by #183 not sure why it is unused now

[yatzek]

Os disk size customisation was removed by #189 I am guessing it was done by mistake?

[lonegunmanb]

Thanks @yatzek , you've saved my day.

I've added a version upgrade test, a breaking change detect for variables and outputs, but still I've missed such breaking change. I'll compose a new pr to fix it, and re-check current version.

[lonegunmanb]

I've re-check the commit, the only missing parts introduced by #189 is storage_os_disk_size_gb, so I'll submit a new pr to fix it. Again, thanks @yatzek for hit this point.