Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom OS disk size #183

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Allow custom OS disk size #183

merged 4 commits into from
Nov 15, 2022

Conversation

yatzek
Copy link
Contributor

@yatzek yatzek commented Oct 19, 2022

Fixes #172

@yatzek
Copy link
Contributor Author

yatzek commented Oct 19, 2022

@microsoft-github-policy-service agree

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #185, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

lonegunmanb
lonegunmanb requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yatzek for opening this pr! We've added a CI pipeline to this repo so would you please rebase your branch to the latest master branch? Thanks!

Btw, I've some questions for your pr.

variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
lonegunmanb
lonegunmanb requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yatzek we've got an issue when the pipeline executed the pr-check job, would you please read this section and help us by running make pre-commit job, then verify your commit with make pr-check? Thanks for your understanding!

@yatzek yatzek temporarily deployed to acctests November 15, 2022 13:11 Inactive
lonegunmanb
lonegunmanb approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yatzek, LGTM!

@lonegunmanb lonegunmanb merged commit d7b537b into Azure:master Nov 15, 2022
This was referenced Nov 15, 2022
Merged
Closed
Closed
Closed
Closed
@yatzek yatzek mentioned this pull request Nov 24, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonegunmanb lonegunmanb lonegunmanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for custom OS disk size
2 participants
@yatzek @lonegunmanb