Terraform 0.13 upgrade #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 13, 2020 16:22
njuCZ
reviewed
Sep 1, 2020
| @@ -14,7 +14,58 @@ This Terraform module deploys Virtual Machines in Azure with the following chara | |||
|
|
|||
| > Note: Terraform module registry is incorrect in the number of required parameters since it only deems required based on variables with non-existent values. The actual minimum required variables depends on the configuration and is specified below in the usage. | |||
|
|
|||
| ## Simple Usage | |||
| ## Usage in Terraform 0.13 | |||
| ```hcl | |||
There was a problem hiding this comment.
I think maybe we should copy the doc in section "Usage in Terraform 0.12" to here too, or move it to top
There was a problem hiding this comment.
Sure. There are two sections, one for TF 0.12 (line 68), one for TF 0.13.
There was a problem hiding this comment.
yes, I think the doc also applies to Example usage TF 0.13?
njuCZ
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.