Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple ssh keys #147

Merged
merged 5 commits into from
Nov 19, 2020
Merged

support multiple ssh keys #147

merged 5 commits into from
Nov 19, 2020

Conversation

sudoapt-getclean
Copy link
Contributor

I needed support for multiple keys, the cleanest way to do that seemed to me to just change the existing var.ssh_keys to a list

An alternative implementation that would be backwards compatible would be to introduce a separate variable ssh_keys and merge them in a local. let me know if you prefer that.

@ghost
Copy link

ghost commented Oct 6, 2020

CLA assistant check
All CLA requirements met.

@yupwei68
Copy link
Contributor

Hi @sudoapt-getclean , thanks for opening this PR.

  1. I prefer not to break the users by add an extra variable "ssh_keys"
  2. Please enabled this feature into fixture/test/main.tf and test if it works when it's assigned and if it works when it's not assigned
  3. Please add this feature into the example of README.md

variables.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@yupwei68 yupwei68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@yupwei68 yupwei68 merged commit 87302ac into Azure:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants