Add NSG Update #17
Merged
Add NSG Update #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dtzar
commented
Oct 13, 2017
dtzar
commented
- Fixes Unable to provision multiple NSGs #16
- Updates Readme for new functionality with Public IPs and boot diagnostic storage
Merged
Add managed data disk example in advanced usage
|
LGTM, I would suggest to change "${var.vm_hostname}${count.index}" into "${var.vm_hostname}-${count.index}" so that the name of all resources attached to that vm have the same format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.