Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor example fix #4

Merged
merged 1 commit into from
Sep 21, 2017
Merged

minor example fix #4

merged 1 commit into from
Sep 21, 2017

Conversation

dtzar
Copy link
Contributor

@dtzar dtzar commented Sep 21, 2017

Fix the Windows Server public DNS IP example name to be valid. Otherwise you get:

* module.mycompute.azurerm_public_ip.vm: 1 error(s) occurred:

* azurerm_public_ip.vm: network.PublicIPAddressesClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="DomainNameLabelReserved" Message="The domain name label mywindowsservers225 is invalid. The name itself or part of the name is a reserved word such as a trademark. Please use a different name." Details=[]

@msftclas
Copy link

@dtzar,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

dcaro
dcaro approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtzar dtzar assigned dcaro and unassigned echuvyrov Sep 21, 2017
@dcaro dcaro merged commit 4a4acdd into master Sep 21, 2017
@dtzar dtzar deleted the readmefix branch September 21, 2017 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcaro dcaro dcaro approved these changes

Assignees

@dcaro dcaro

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtzar @msftclas @dcaro @echuvyrov