Improve the workflow #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
metacpp
commented
Jan 9, 2018
metacpp
commented
- Added build arguments to setup terraform environment during building image.
- Update the Gemfile to add back missed gems to avoid rake e2e issue.
- Simplify the documentation to run test and build.
… gem in the package and update the readme.
WodansSon
approved these changes
Jan 9, 2018
dtzar
reviewed
Jan 10, 2018
| @@ -6,4 +6,6 @@ group :test do | |||
| git 'https://github.com/Azure/terramodtest.git' do | |||
| gem 'terramodtest', :tag => 'v0.1.0' | |||
| end | |||
| gem 'test-kitchen', '1.16.0' | |||
There was a problem hiding this comment.
Why do you need these since they are already included with same version on the base image?
| @@ -150,7 +150,7 @@ More specifically this provisions: | |||
| Test | |||
| ----- | |||
|
|
|||
| ### Configuration Prerequisites | |||
There was a problem hiding this comment.
These things are required, why remove "Prerequisites"?
|
|
||
| ```sh | ||
| docker run -v ~/.ssh:/root/.ssh/ -v $MODULE_PATH/logs:/tf-test/module/.kitchen -v $MODULE_PATH:/tf-test/module -e ARM_CLIENT_ID -e ARM_TENANT_ID -e ARM_SUBSCRIPTION_ID -e ARM_CLIENT_SECRET -e ARM_TEST_LOCATION -e ARM_TEST_LOCATION_ALT --rm azure-compute rake -f ../Rakefile build |
There was a problem hiding this comment.
If you don't do the volume mounts then it will never test their code.
| ``` | ||
|
|
||
| This runs the end to end tests: | ||
|
|
||
| ```sh | ||
| docker run -v ~/.ssh:/root/.ssh/ -v $MODULE_PATH/logs:/tf-test/module/.kitchen -v $MODULE_PATH:/tf-test/module -e ARM_CLIENT_ID -e ARM_TENANT_ID -e ARM_SUBSCRIPTION_ID -e ARM_CLIENT_SECRET -e ARM_TEST_LOCATION -e ARM_TEST_LOCATION_ALT --rm azure-compute rake -f ../Rakefile e2e | ||
| $ docker run -v ~/.ssh:/root/.ssh/ --rm azure-compute /bin/bash -c "rake e2e" |
There was a problem hiding this comment.
need the volume mount to map the local cloned code to do e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.