-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boot diagnostics option #7
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
50a869c
Add boot diagnostics option
092753e
Add vm_hostname to nic interface name for more comprehension
ed66005
Add vm_hostname to os_disk name
84600bb
Allow to delete data disk on termination
67a4dd3
Add storage type variable for boot diag storage account
29d98c7
Fixed issue where Azure/compute/azurerm module was called instead of …
21f40f3
PR #12 2nd example correction
dtzar 0e6b530
PR#10 enhance nic_names
dtzar 5203610
PR #11 enhance os_disk_name add delete_os_disk_on_termination
dtzar 4cc1a4a
Fix issue when boot_diagnostics is set to false
ee7d8db
Miss to add the fix on windows boxes
a7fcd85
Add boot diagnostics option
ffae7f4
Add storage type variable for boot diag storage account
a265ddc
Fix issue when boot_diagnostics is set to false
61941e0
Miss to add the fix on windows boxes
9ee01ee
Merge
ca49841
auto generated name for bootdiag sa
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it seems this code is not working for me because when I use the default of setting
boot_diagnostics
tofalse
, I still get these errors:When I set it to true, it works as expected. I'm using the latest terraform v0.10.7 with Azure module 0.2.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review. I fixed this issue in commit 4cc1a4a.