Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML support TCGC Implementation #704

Closed
Tracked by #705
lmazuel opened this issue Apr 19, 2024 · 0 comments
Closed
Tracked by #705

XML support TCGC Implementation #704

lmazuel opened this issue Apr 19, 2024 · 0 comments
Assignees
@tadelesh
Labels
feature New feature or request lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@lmazuel
Copy link
Member

lmazuel commented Apr 19, 2024 •
edited
Loading

Make sure TCGC makes available the XML metadata

https://typespec.io/docs/next/libraries/xml/reference

Package is @typespec/xml
@lmazuel lmazuel mentioned this issue Apr 19, 2024
Open
@lmazuel lmazuel added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Apr 19, 2024
@lmazuel lmazuel assigned live1206 and tadelesh and unassigned tadelesh and live1206 Apr 23, 2024
@tadelesh tadelesh added the feature New feature or request label Jun 11, 2024
@iscai-msft iscai-msft mentioned this issue Jun 24, 2024
Merged
tadelesh added a commit that referenced this issue Jun 26, 2024
@tadelesh
[tcgc] support generic type decorators in sdk types (#966)
660b587 
resolve: #829, #704 

current design:
1. use whitelist configured in `tspconfig.yaml` to do decorators
filtering, support equal/regex comparison
2. use `jsValue` from typespec decorator arguments to get arguments'
value
3. only handle arguments value of typing with
number/string/boolean/null/tsp enum member value/tsp literal value,
other types will add a diagnostic warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadelesh tadelesh

Labels
feature New feature or request lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lmazuel @tadelesh @live1206 @iscai-msft @weidongxu-microsoft