Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Typo in SdkDatetimeType #799

Closed
4 tasks done
ArcturusZhang opened this issue May 8, 2024 · 0 comments · Fixed by #1067
Closed
4 tasks done

[Bug]: Typo in SdkDatetimeType #799

ArcturusZhang opened this issue May 8, 2024 · 0 comments · Fixed by #1067
Assignees
@iscai-msft
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@ArcturusZhang
Copy link
Member

Describe the bug

Spell check will flag this word Datetime, but it should be DateTime.
There are inconsistencies among TCGC:

typespec-azure/packages/typespec-client-generator-core/src/interfaces.ts

Line 222 in be1e2c3

export type SdkDatetimeType = SdkUtcDatetimeType | SdkOffsetDatetimeType;

typespec-azure/packages/typespec-client-generator-core/src/interfaces.ts

Line 215 in be1e2c3

kind: "utcDateTime";

typespec-azure/packages/typespec-client-generator-core/src/interfaces.ts

Line 219 in be1e2c3

kind: "offsetDateTime";

Reproduction

Just check the code:

typespec-azure/packages/typespec-client-generator-core/src/interfaces.ts

Line 222 in be1e2c3

export type SdkDatetimeType = SdkUtcDatetimeType | SdkOffsetDatetimeType;

typespec-azure/packages/typespec-client-generator-core/src/interfaces.ts

Line 215 in be1e2c3

kind: "utcDateTime";

typespec-azure/packages/typespec-client-generator-core/src/interfaces.ts

Line 219 in be1e2c3

kind: "offsetDateTime";

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
  • Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@ArcturusZhang ArcturusZhang added the bug Something isn't working label May 8, 2024
@markcowl markcowl added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label May 13, 2024
@tadelesh tadelesh mentioned this issue May 15, 2024
Closed
@iscai-msft iscai-msft mentioned this issue Jun 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 25, 2024
@iscai-msft
[tcgc] unify datetime casing by renaming interface types (#1067)
83851cb 
fixes #799

---------

Co-authored-by: iscai-msft <isabellavcai@gmail.com>
markcowl pushed a commit to markcowl/typespec-azure that referenced this issue Jun 26, 2024
@iscai-msft @markcowl
[tcgc] unify datetime casing by renaming interface types (Azure#1067)
a1a4bad 
fixes Azure#799

---------

Co-authored-by: iscai-msft <isabellavcai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iscai-msft iscai-msft

Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tcgc] unify datetime casing by renaming interface types Azure/typespec-azure
4 participants
@lmazuel @markcowl @ArcturusZhang @iscai-msft