Add name and tspNamespace to SdkArrayType
#1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changed packages have been documented.
Show changes
|
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1000/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1000/ |
ArcturusZhang
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar and
joheredi
as code owners
microsoft-github-policy-service
bot
added
the
lib:tcgc
ArcturusZhang
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
This was referenced Jun 13, 2024
tadelesh
reviewed
Jun 14, 2024
ArcturusZhang
force-pushed
the
add-name-and-namespace-to-array
branch
from
0506f30
to
ca6a8a0
Compare
ArcturusZhang
changed the title
name and namespace to SdkArrayTypename and tspNamespace to SdkArrayType
.chronus/changes/add-name-and-namespace-to-array-2024-5-13-1-59-45.md
Outdated
Show resolved
Hide resolved
haolingdong-msft
approved these changes
Jun 18, 2024
…9-45.md Co-authored-by: Haoling Dong <87355844+haolingdong-msft@users.noreply.github.com>
tadelesh
reviewed
Jun 18, 2024
tadelesh
approved these changes
Jun 18, 2024
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Jun 26, 2024
Fixes Azure#999 This PR adds name and namespace to `SdkArrayType` so that we could know if this array is an ordinary array, or an array created somewhere which needs special handling on the SDK generator side. --------- Co-authored-by: Haoling Dong <87355844+haolingdong-msft@users.noreply.github.com>
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #999
This PR adds name and namespace to
SdkArrayTypeso that we could know if this array is an ordinary array, or an array created somewhere which needs special handling on the SDK generator side.