Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CanonicalEmitter] Add option and isArmCommonType check #1065

Merged
merged 15 commits into from
Jun 26, 2024

Conversation

dinwa-ms
Copy link
Contributor

This PR addressed 2 issues:

  1. add option "use-read-only-status-schema" to fix ProvisioningStateMustBeReadOnly bug;
    The bug is mentioned here https://github.com/Azure/azure-rest-api-specs/discussions/29471 and the suggested walkaround is set option "use-read-only-status-schema" to true.
    Canonical emitter doesn't have this option. So add this option to the emitter.
    image

  2. add isArmCommonType check to avoid decorator validation in canonical emitter
    Canonical emitter will generate warning when @typeChangedFrom decorator is used. To make sure this not apply to common type, add isArmCommonType check

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would remove the optionalk altogether as dicussed. Also, looks like you need to remove the test that checks for behavior when read-onlly-status-schema is turned off.

Otherwise, looks good.

@markcowl markcowl added this pull request to the merge queue Jun 26, 2024
Merged via the queue into Azure:main with commit ed1017c Jun 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants