Enums are not extensible by default anymore

.chronus/changes/enum-model-as-string-false-2024-2-21-19-56-37.md

@@ -0,0 +1,8 @@
+---
+# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
+changeKind: breaking
+packages:
+  - "@azure-tools/typespec-autorest"
+---
+
+Enums are not extensible by default anymore. Update to an extensible union `union Foo {a: "a", b: "b", string}`

packages/typespec-autorest/src/openapi.ts

@@ -7,7 +7,6 @@ import {
   getLroMetadata,
   getPagedResult,
   getUnionAsEnum,
-  isFixed,
 } from "@azure-tools/typespec-azure-core";
 import {
   getArmCommonTypeOpenAPIRef,
@@ -1925,7 +1924,7 @@ export async function getOpenAPIForService(
     if (type.node && type.node.parent && type.node.parent.kind === SyntaxKind.ModelStatement) {
       schema["x-ms-enum"] = {
         name: type.node.parent.id.sv,
-        modelAsString: true,
+        modelAsString: false,
       };
     } else if (type.kind === "String") {
       schema["x-ms-enum"] = {
@@ -1934,7 +1933,7 @@ export async function getOpenAPIForService(
     } else if (type.kind === "Enum") {
       schema["x-ms-enum"] = {
         name: type.name,
-        modelAsString: isFixed(program, type) ? false : true,
+        modelAsString: false,
       };
 
       const values = [];

packages/typespec-autorest/test/host.test.ts

@@ -125,7 +125,7 @@ describe("typespec-autorest: host/x-ms-parameterized-host", () => {
           required: true,
           type: "string",
           enum: ["westus", "eastus"],
-          "x-ms-enum": { modelAsString: true, name: "Region" },
+          "x-ms-enum": { modelAsString: false, name: "Region" },
         },
       ],
     });

packages/typespec-autorest/test/models.test.ts

@@ -314,7 +314,7 @@ describe("typespec-autorest: model definitions", () => {
           enum: ["a-value", "b"],
           "x-ms-enum": {
             name: "MyEnum",
-            modelAsString: true,
+            modelAsString: false,
             values: [
               { name: "a", value: "a-value" },
               { name: "b", value: "b" },
@@ -709,7 +709,7 @@ describe("typespec-autorest: model definitions", () => {
         type: "string",
         enum: ["dog", "cat"],
         "x-ms-enum": {
-          modelAsString: true,
+          modelAsString: false,
           name: "PetKind",
         },
       });

packages/typespec-autorest/test/openapi-output.test.ts

@@ -617,41 +617,25 @@ describe("typespec-autorest: enums", () => {
     type: "string",
     enum: ["foo", "bar"],
   });
+
   it("create basic enum without values", async () => {
-    const res = await oapiForModel(
-      "Foo",
-      `
-        enum Foo {foo, bar}
-      `
-    );
+    const res = await oapiForModel("Foo", `enum Foo {foo, bar}`);
 
     const schema = res.defs.Foo;
     deepStrictEqual(schema, {
       ...enumBase,
       "x-ms-enum": {
-        modelAsString: true,
+        modelAsString: false,
         name: "Foo",
       },
     });
   });
 
-  it("create fixed enum", async () => {
-    const res = await oapiForModel(
-      "Foo",
-      `
-        @fixed
-        enum Foo {foo, bar}
-      `
-    );
+  it("enums are marked with modelAsString false by default", async () => {
+    const res = await oapiForModel("Foo", `enum Foo {foo, bar}`);
 
     const schema = res.defs.Foo;
-    deepStrictEqual(schema, {
-      ...enumBase,
-      "x-ms-enum": {
-        modelAsString: false,
-        name: "Foo",
-      },
-    });
+    deepStrictEqual(schema["x-ms-enum"].modelAsString, false);
   });
 
   it("create enum with doc on a member", async () => {
@@ -670,7 +654,7 @@ describe("typespec-autorest: enums", () => {
     deepStrictEqual(schema, {
       ...enumBase,
       "x-ms-enum": {
-        modelAsString: true,
+        modelAsString: false,
         name: "Foo",
         values: [
           {
@@ -702,7 +686,7 @@ describe("typespec-autorest: enums", () => {
     deepStrictEqual(schema, {
       ...enumBase,
       "x-ms-enum": {
-        modelAsString: true,
+        modelAsString: false,
         name: "Foo",
         values: [
           {
@@ -734,7 +718,7 @@ describe("typespec-autorest: enums", () => {
       type: "number",
       enum: [0, 1],
       "x-ms-enum": {
-        modelAsString: true,
+        modelAsString: false,
         name: "Test",
         values: [
           {

packages/typespec-autorest/test/parameters.test.ts

@@ -350,7 +350,7 @@ describe("typespec-autorest: parameters", () => {
               required: true,
               type: "string",
               enum: ["one", "two"],
-              "x-ms-enum": { modelAsString: true, name: "Foo" },
+              "x-ms-enum": { modelAsString: false, name: "Foo" },
             });
           });
 
@@ -364,7 +364,7 @@ describe("typespec-autorest: parameters", () => {
               items: {
                 type: "string",
                 enum: ["one", "two"],
-                "x-ms-enum": { modelAsString: true, name: "Foo" },
+                "x-ms-enum": { modelAsString: false, name: "Foo" },
               },
             });
           });