Add no-string-discriminator linter rule #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
|
All changed packages have been documented.
Show changes
|
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/693/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/693/ |
markcowl
reviewed
Apr 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2024
All rules about the previous state of `@fixed` and open enums - no `@fixed` - we should deprecate it as its a noop - no fixed enum discriminator - new rule taking over recommending unions #693 --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
markcowl
requested changes
May 21, 2024
markcowl
approved these changes
Jun 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #97 add linter rule to recommend the discriminator property to be explicitly defined as an extensible union