Only the original thread that created a view hierarchy can touch its views.

[Eqbalazar]

I am getting error after login , upgrade ADAL version from 1.12.0 to 1.13.2

12-18 09:54:24.153 9842-9930/? E/AndroidRuntime: FATAL EXCEPTION: AcquireTokenRequestHandlerThread
                                                 Process: com.companyname.appname, PID: 9842
                                                 android.view.ViewRootImpl$CalledFromWrongThreadException: 
												 Only the original thread that created a view hierarchy can touch its views.
                                                     at android.view.ViewRootImpl.checkThread(ViewRootImpl.java:8197)
                                                     at android.view.ViewRootImpl.requestLayout(ViewRootImpl.java:1268)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.support.v4.widget.DrawerLayout.requestLayout(Unknown Source)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.support.v7.widget.av.requestLayout(Unknown Source)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.view.View.requestLayout(View.java:20084)
                                                     at android.widget.TextView.checkForRelayout(TextView.java:8382)
                                                     at android.widget.TextView.setText(TextView.java:5000)
                                                     at android.widget.TextView.setText(TextView.java:4827)
                                                     at android.widget.TextView.setText(TextView.java:4802)
                                                     at com.companyname.appname.MainActivity.A(Unknown Source)
                                                     at com.companyname.appname.MainActivity.d(Unknown Source)
                                                     at com.companyname.appname.MainActivity$6.a(Unknown Source)
                                                     at com.companyname.appname.MainActivity$6.onSuccess(Unknown Source)
                                                     at com.microsoft.aad.adal.AcquireTokenRequest$CallbackHandler$2.run(Unknown Source)
                                                     at android.os.Handler.handleCallback(Handler.java:739)
                                                     at android.os.Handler.dispatchMessage(Handler.java:95)
                                                     at android.os.Looper.loop(Looper.java:158)
                                                     at android.os.HandlerThread.run(HandlerThread.java:61)
12-18 09:54:24.158 2788-3090/? W/ActivityManager:   Force finishing activity com.companyname.appname/.MainActivity

[heidijinxujia]

Hi @Eqbalazar thank you for reporting this issue. This is not clear which call did you made and get this error. The stacktrace here only shows CalledFromWrongThreadException is thrown which is from Android. Could you attach your code where the adal auth call is made? Is it from main thread or background thread? Please attach the complete adal logs as well.

[Eqbalazar]

Hi @heidijinxujia ,
It is in Background Service :

FileTokenCache _FileTokenCacheStore = new FileTokenCache(getApplicationContext(),
"fileCacheToken.dat");
AuthenticationContext m = new AuthenticationContext(getApplicationContext(),
Constants.AUTHORITY_URL, _FileTokenCacheStore);

I have to do refresh token in back ground in order to prevent loging again by users.

[heidijinxujia]

Thank you for the quick reply. @Eqbalazar Which adal API you are calling when trying to refresh the token?

[Eqbalazar]

Hi @heidijinxujia ,
ADAL Version 1.13.2

[heidijinxujia]

Hi @Eqbalazar The ADAL API is referring to the function you called in your client app code, not the version number. For exception, are you making an acquireTokenCall? If so, which function are you calling? Thanks.

[heidijinxujia]

Close the issue because we have not got the reply from customer for more than two weeks. Please feel free to reopen it if you got further question. Thanks.

[MoBo]

I have the same issue. AuthenticationCallback seem to invoked on a background thread in Version 1.13.3. In Version 1.3.0 the callback was executed on the main thread. Is this the expected behaviour in the new version?

[iambmelt]

Hello @MoBo @Eqbalazar -- From my testing, I can confirm this as an unintended change that occurred between versions 1.13.1 and 1.13.2. I will consult with my team and see that a test case is added for future releases.

Reopening this issue, as it's now confirmed.

[iambmelt]

@nazukj Just putting this on your radar: we can follow-up regarding next steps, milestone, etc.

/cc @heidijinxujia @addev-ashish @piqiums

[piqiums]

@Eqbalazar, please look at

azure-activedirectory-library-for-android/adal/src/main/java/com/microsoft/aad/adal/AcquireTokenRequest.java

Line 878 in 01aae1f

public CallbackHandler(Handler ref, AuthenticationCallback<AuthenticationResult> callbackExt) {

In the 'AuthenticationCallback callbackExt', in the method 'onError' & "onSuccess", please update UI on UI Thread via "runOnUiThread". Please don't suppose these 2 callback methods would definitely be called on UI thread. https://developer.android.com/reference/android/app/Activity.html#runOnUiThread(java.lang.Runnable)

The "AcquireTokenRequest" should not run on UI thread since it's not UI related, and we moved it to a non-UI thread to keep the UI thread responsive to the user input.

[piqiums]

@Eqbalazar , is your app released or still in development? thanks

[Eqbalazar]

Hi @piqiums , I tested in Development , I am using 1.13.1 on release .

[nazukj]

@Eqbalazar, is this working for you with Ping's suggestion?

[Eqbalazar]

Is working. Thanks ,

…

On Jan 31, 2018 4:27 PM, "Nazuk Jain" ***@***.***> wrote: @Eqbalazar <https://github.com/eqbalazar>, is this working for you with Ping's suggestion? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1076 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHEXNEEreVChcydSoDN9Bg1D8t9hTp7Eks5tQNpigaJpZM4RFoJ_> .