Fix AuthenticationDialog crash; Add support for testing Authenticatio… #1254
Conversation
…nDialog to automation app; Add stress test to automation test app; Add web view open to automation test app
| import android.webkit.WebView; | ||
| import android.webkit.WebViewClient; | ||
|
|
||
| public class CustomWebViewClient extends WebViewClient { |
There was a problem hiding this comment.
Just curious why a CustomWebViewClient if we are just returning false from shouldOverrideUrl
There was a problem hiding this comment.
False indicates that the webview itself handles the redirect. Which is fine in this case.
| @@ -128,6 +145,12 @@ private void launchAuthenticationInfoActivity(int flowCode) { | |||
| this.startActivity(intent); | |||
| } | |||
|
|
|||
| private void openWevViewActivity(){ | |||
There was a problem hiding this comment.
Typo : openWebViewActivity
| @@ -128,6 +145,12 @@ private void launchAuthenticationInfoActivity(int flowCode) { | |||
| this.startActivity(intent); | |||
| } | |||
|
|
|||
| private void openWevViewActivity(){ | |||
| final Intent intent = new Intent(); | |||
| intent.setClass(mContext, WebViewActivity.class); | |||
There was a problem hiding this comment.
Nit : we can use Intent's constructor to set class and context directly like
final Intent intent = new Intent(mContext, WebViewActivity.class);
There was a problem hiding this comment.
I'll fix since I'm fixing the typo
| @@ -148,9 +156,19 @@ private void performAuthentication() { | |||
| validateUserInput(inputItems, flowCode); | |||
|
|
|||
| setAuthenticationData(inputItems); | |||
| AuthenticationSettings.INSTANCE.setUseBroker(true); | |||
| AuthenticationSettings.INSTANCE.setUseBroker(mUseBroker); | |||
There was a problem hiding this comment.
I had the same change which went in. Conflict needs to be resolved here
|
Nothing further to add to @kreedula at this time |
|
Thanks @shoatman. LGTM 👍 |
|
Related: #1261 |
…nDialog to automation app; Add stress test to automation test app; Add web view open to automation test app
This closes #1234