Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating publishing tasks #1792

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Conversation

melissaahn
Copy link
Contributor

@melissaahn melissaahn commented May 23, 2024

Summary

(still in progress)
This PR:

Pipeline run: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1304918&view=results&j=76b33e1f-4828-5f2f-d07d-022319483d4a

Artifacts created on a test pipeline run: https://identitydivision.visualstudio.com/Engineering/_artifacts/feed/AndroidADAL/maven/com.microsoft.aad%2Fadal/overview/1.0.20240523-melissaahn-PublishingChanges

Note the names of the artifacts and that most of the dependencies are listed under Runtime now instead of Compile. This means that our external dependencies which we declare with implementation configuration are no longer leaking to our consumers. The configurations are now working as described here.
Consumers who have relied on the libraries for external dependencies will now need to add the dependencies directly.

@melissaahn melissaahn marked this pull request as ready for review May 24, 2024 00:53
@melissaahn melissaahn requested a review from a team as a code owner May 24, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants