This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
authorization code flow: support token cache #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugangw-msft
force-pushed
the
authzcache
branch
from
745217f
to
d326031
Compare
|
//cc: @rayluo |
rayluo
reviewed
Apr 24, 2018
tests/test_authorization_code.py
Outdated
|
|
||
| # the caching layer adds a few extra fields, let us pop them out for easier verification | ||
| for k in ['_clientId', '_authority', 'resource']: | ||
| token_response.pop(k) |
There was a problem hiding this comment.
@yugangw-msft
Thanks for identifying this little quirk and working it out!
Nitpicking: I would suggest to use a slightly safer way to rewrite this line to token_response.pop(k, None) because:
- conceptually those tricky side effects are just implementation details, which could potentially be changed in future;
- at the very least, this test case should not rely on an assumption that those side effects would always exist.
I will send out a new commit for it, if you don't mind. Oh, I forgot that I probably do not have permission to send commits to your fork repo. So perhaps the easier way is you make that change in your PR, again, if you don't mind. :-)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.