This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Adding auth code flow support for public client #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
reviewed
May 17, 2018
adal/authentication_context.py
Outdated
| application. | ||
| :param str client_secret: (only for confidential clients)The OAuth | ||
| client secret of the calling application. | ||
| :param str code_verifier: (optional)The code verifier that was used to |
There was a problem hiding this comment.
Please remove this document too. We don't need it yet. :-)
Also github detects there will be a merge conflict for this PR. And that is because this branch was created from an older dev branch. So another learning experience here: always do git pull origin dev first, before you do git checkout -b my-cool-new-feature.
rayluo
approved these changes
May 17, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for enabling Authorization code flow for public clients.
This PR will fix #140