Add descriptive x5c comment to WithCertificate #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SameerK-MSFT
approved these changes
Dec 23, 2021
bgavrilMS
reviewed
Jan 4, 2022
| @@ -94,9 +94,15 @@ public ConfidentialClientApplicationBuilder WithCertificate(X509Certificate2 cer | |||
|
|
|||
| /// <summary> | |||
| /// Sets the certificate associated with the application. | |||
| /// This method allows to specify if the x5c claim (public key of the certificate) should be sent to Azure AD. | |||
There was a problem hiding this comment.
- It's not the public key of the cert that's being sent, it's the certificate chain. Please reference https://datatracker.ietf.org/doc/html/rfc7517#section-4.7
- As far as I know, this is only available for 1st parties. This should be highlighted
- The URL is internal and we'll get flagged for posting internal stuff. Can you add or modify a page in our wiki instead where it just states "This is for 1st party Microsoft apps only. For details please see ..."
There was a problem hiding this comment.
- What's going to flag us? Even if it's aka.ms link, and not a direct link?
So update aka.ms link to point to a new SNI wiki page which has a link to internal SNI doc?
There was a problem hiding this comment.
An aka.ms link is fine, but not if it points to an internal doc. All aka.ms link that go onto the public docs must point to public pages. We started getting docs bugs because of this.
You can also point to AzureAD/microsoft-authentication-library-for-python#60
There was a problem hiding this comment.
bgavrilMS
approved these changes
Jan 4, 2022
|
Approved with comments. Main thing is to highlight that X5C is for 1st party only (despite the misleading internal docs) |
pmaytak
force-pushed
the
pmaytak/sendx5c-comments
branch
from
5d25418
to
a5c5115
Compare
bgavrilMS
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
Update X5C related comments in WithSendX5C and WithCertificate.
Testing
Performance impact