Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track MSAL node SKU for broker flows #7213

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Track MSAL node SKU for broker flows #7213

merged 2 commits into from
Jul 19, 2024

Conversation

konstantin-msft
Copy link
Collaborator

  • Track MSAL node SKU for broker flows.
  • Move SKU instrumentation to common

@konstantin-msft
- Track MSAL node SKU for broker flows.
0d006aa 
- Move SKU instrumentation to common
@github-actions github-actions bot added documentation Related to documentation. msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package extensions Related to extensions for the base libraries labels Jul 19, 2024
tnorling
tnorling approved these changes Jul 19, 2024
View reviewed changes
extensions/msal-node-extensions/src/broker/NativeBrokerPlugin.ts
AADServerParamKeys.X_CLIENT_EXTRA_SKU,
ServerTelemetryManager.makeExtraSkuString({
skus,
extensionName: "msal.node.ext",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a constant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't as skus is picked up from request.extraParameters.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to msal.node.ext

@konstantin-msft konstantin-msft merged commit 97fb781 into dev Jul 19, 2024
9 checks passed
@konstantin-msft konstantin-msft deleted the report_msal_node_sku branch July 19, 2024 20:12
@nechry nechry mentioned this pull request Aug 14, 2024
Merged
@urbankrepel urbankrepel mentioned this pull request Aug 15, 2024
Merged
@cvs-ops cvs-ops mentioned this pull request Aug 24, 2024
Open
@GodsonLeigh GodsonLeigh mentioned this pull request Sep 2, 2024
Closed
@ScenarioFactory ScenarioFactory mentioned this pull request Sep 2, 2024
Open
@urbankrepel urbankrepel mentioned this pull request Sep 7, 2024
Merged
This was referenced Sep 18, 2024
Closed
Closed
@AbidemiAdio AbidemiAdio mentioned this pull request Sep 19, 2024
Open
@beclamide beclamide mentioned this pull request Sep 19, 2024
Open
@rohanssalunkhe rohanssalunkhe mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@peterzenz peterzenz peterzenz approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@trwalke trwalke Awaiting requested review from trwalke trwalke is a code owner

@pmaytak pmaytak Awaiting requested review from pmaytak pmaytak is a code owner

@gladjohn gladjohn Awaiting requested review from gladjohn gladjohn is a code owner

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava neha-bhargava is a code owner

@rayluo rayluo Awaiting requested review from rayluo rayluo is a code owner

@Avery-Dunn Avery-Dunn Awaiting requested review from Avery-Dunn Avery-Dunn is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. extensions Related to extensions for the base libraries msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konstantin-msft @tnorling @peterzenz