Proposal for the parameters of AddProtectedApi ... methods #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I propose to get rid of hybrid methods, that is provide only: - configuration and section name - or delegates to set the option (several delegates)
pmaytak
reviewed
Mar 30, 2020
src/Microsoft.Identity.Web/WebApiServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
| } | ||
| /// <summary> | ||
| /// Protects the Web API with Microsoft identity platform (formerly Azure AD v2.0) | ||
| /// This supposes that the configuration files have a section named configSectionName (typically "AzureAD") |
There was a problem hiding this comment.
This comment is no longer applicable.
|
|
||
| builder.Services.AddHttpContextAccessor(); | ||
| builder.Services.AddSingleton<IJwtBearerMiddlewareDiagnostics, JwtBearerMiddlewareDiagnostics>(); | ||
|
|
||
| // Change the authentication configuration to accommodate the Microsoft identity platform endpoint (v2.0). | ||
| builder.AddJwtBearer(jwtBearerScheme, options => | ||
| { | ||
| var microsoftIdentityOptions = configuration.GetSection(configSectionName).Get<MicrosoftIdentityOptions>(); | ||
| // TODO: | ||
| // Suspect. Why not get the IOption<MicrosoftIdentityOptions>? |
| bool subscribeToJwtBearerMiddlewareDiagnosticsEvents = false) | ||
| { | ||
| builder.Services.Configure(jwtBearerScheme, jwtOptionsMapper); | ||
| builder.Services.Configure<MicrosoftIdentityOptions>(microsoftIdentityOptionsMapper); |
There was a problem hiding this comment.
I think the generic type can be removed, since it can be inferred or we can add one in the line above for consistency and if we want to be explicit or not. (Same applied to similar methods below).
src/Microsoft.Identity.Web/WebApiServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/WebApiServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
|
Looks good. I'll take a look at the related web app work. thanks. In reply to: 383584388 [](ancestors = 383584388) |
…nd delegates) Addressing pmartak's PR comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to get rid of hybrid methods, that is provide only:
@jennyf19 : let's discuss this when/if you have time.