Clean up public api for web app #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sProtectedWebApi Remove obsolete methods Update test apps
pmaytak
approved these changes
Mar 31, 2020
| builder.Services.Configure(openIdConnectScheme, configureOptions); | ||
| builder.Services.Configure<MicrosoftIdentityOptions>(options => configuration.Bind(configSectionName, options)); | ||
| builder.Services.Configure(openIdConnectScheme, configureOpenIdConnectOptions); | ||
|
|
There was a problem hiding this comment.
Nit: remove extra line. #Resolved
|
|
||
| var microsoftIdentityOptions = configuration.GetSection(configSectionName).Get<MicrosoftIdentityOptions>(); | ||
| var b2COidcHandlers = new AzureADB2COpenIDConnectEventHandlers(openIdConnectScheme, microsoftIdentityOptions); |
There was a problem hiding this comment.
Nit: I think it should be b2cOidcHandlers since B2C is one acronym. #Resolved
|
|
||
| services.Configure<OpenIdConnectOptions>(openIdConnectScheme, options => | ||
| { | ||
| // Response type |
There was a problem hiding this comment.
Nit: perhaps redundant comment? #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddSignInandAddWebAppCallsWebApiPart of [Investigate] Investigate the use of the ConfidentialClientOptions and MicrosoftIdentityOptions in TokenAcquisition #37