Fix for issue: CosmosDB to CosmosDB doesn't migrate "Id" field #100 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kindly ping. |
|
The existing behavior is as designed for the normal use case where some id field exists and the expectation is that it will be used as the string "id" required by Cosmos DB, and simply changing the default casing handling would break that. An additional settings option can be used to change the behavior to what you're requesting though. |
bowencode
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those who are using EntitFrameworkCore CosmosDb provider it is very important to make a difference between 'id' and 'Id' field on JSON objects. This fix handles it. I ran unit tests, all passed.
Reported Issue: #100