Skip to content

Commit

Permalink
Make warning inhibitors work on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
witemple-msft committed Jan 24, 2022
1 parent 5c4c828 commit d28baf0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions common/tools/dev-tool/src/config/rollup.base.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,22 +68,22 @@ export type WarningInhibitor = (warning: RollupWarning) => boolean;
function ignoreNiseSinonEval(warning: RollupWarning): boolean {
return (
warning.code === "EVAL" &&
(warning.id?.includes("node_modules/nise") || warning.id?.includes("node_modules/sinon")) ===
true
(warning.id?.includes(["node_modules", "nise"].join(path.sep)) ||
warning.id?.includes(["node_modules", "sinon"].join(path.sep))) === true
);
}

function ignoreChaiCircularDependency(warning: RollupWarning): boolean {
return (
warning.code === "CIRCULAR_DEPENDENCY" &&
warning.importer?.includes("node_modules/chai") === true
warning.importer?.includes(["node_modules", "chai"].join(path.sep)) === true
);
}

function ignoreOpenTelemetryThisIsUndefined(warning: RollupWarning): boolean {
return (
warning.code === "THIS_IS_UNDEFINED" &&
warning.id?.includes("node_modules/@opentelemetry/api") === true
warning.id?.includes(["node_modules", "@opentelemetry", "api"].join(path.sep)) === true
);
}

Expand Down

0 comments on commit d28baf0

Please sign in to comment.