[Hub Generated] Review request for Microsoft.Consumption to add versi…

…on stable/2019-10-01 (Azure#12347) * Fixed various Swagger Correctness issues * removed readonly property from ThresholdType * added default value to ThresholdType to fix error * updated ContactEmails/ContactGroups and Forecasts * fixed descriptions & examples. removed extra field * added missing "properties/" to example * updated contactGroups description * reformatted description
AzureSDKAutomation · Jan 16, 2021 · 1be3813 · 1be3813
1 parent 5dd055d
commit 1be3813
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/...ion/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json b/...ion/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json
@@ -344,7 +344,7 @@
           "Budgets"
         ],
         "operationId": "Budgets_CreateOrUpdate",
-        "description": "The operation to create or update a budget. Update operation requires latest eTag to be set in the request mandatorily. You may obtain the latest eTag by performing a get operation. Create operation does not require eTag.",
+        "description": "The operation to create or update a budget. You can optionally provide an eTag if desired as a form of concurrency control. To obtain the latest eTag for a given budget, perform a get operation prior to your put operation.",
         "externalDocs": {
           "url": "https://docs.microsoft.com/en-us/rest/api/consumption/"
         },
@@ -1421,7 +1421,7 @@
         ],
         "x-ms-odata": "#/definitions/Forecast",
         "operationId": "Forecasts_List",
-        "description": "Lists the forecast charges by subscriptionId.",
+        "description": "Lists the forecast charges for scope defined. Please note that this API is no longer actively under development. We recommend using our new Forecast API moving forward: https://docs.microsoft.com/en-us/rest/api/cost-management/forecast/usage.",
         "externalDocs": {
           "url": "https://docs.microsoft.com/en-us/rest/api/consumption/"
         },
@@ -3887,7 +3887,7 @@
           "$ref": "#/definitions/BudgetTimePeriod"
         },
         "filter": {
-          "description": "May be used to filter budgets by resource group, resource, or meter.",
+          "description": "May be used to filter budgets by user-specified dimensions and/or tags.",
           "type": "object",
           "$ref": "#/definitions/BudgetFilter"
         },
@@ -4044,12 +4044,12 @@
           "format": "decimal"
         },
         "contactEmails": {
-          "description": "Email addresses to send the budget notification to when the threshold is exceeded.",
+          "description": "Email addresses to send the budget notification to when the threshold is exceeded. Must have at least one contact email or contact group specified at the Subscription or Resource Group scopes. All other scopes must have at least one contact email specified.",
           "type": "array",
           "items": {
             "type": "string"
           },
-          "minItems": 1,
+          "minItems": 0,
           "maxItems": 50
         },
         "contactRoles": {
@@ -4060,7 +4060,7 @@
           }
         },
         "contactGroups": {
-          "description": "Action groups to send the budget notification to when the threshold is exceeded.",
+          "description": "Action groups to send the budget notification to when the threshold is exceeded. Must be provided as a fully qualified Azure resource id. Only supported at Subscription or Resource Group scopes.",
           "type": "array",
           "items": {
             "type": "string"
@@ -4077,7 +4077,8 @@
           "x-ms-enum": {
             "name": "ThresholdType",
             "modelAsString": true
-          }
+          },
+          "default": "Actual"
         }
       },
       "required": [
@@ -4214,7 +4215,7 @@
           "readOnly": true
         },
         "grain": {
-          "description": "The granularity of forecast.",
+          "description": "The granularity of forecast. Please note that Yearly is not currently supported in this API. The API will provide responses in the Monthly grain if Yearly is selected. To get yearly grain data, please use our newer Forecast API.",
           "type": "string",
           "enum": [
             "Daily",

diff --git a/...-manager/Microsoft.Consumption/stable/2019-10-01/examples/ForecastsListFilterByDates.json b/...-manager/Microsoft.Consumption/stable/2019-10-01/examples/ForecastsListFilterByDates.json
@@ -2,7 +2,7 @@
   "parameters": {
     "api-version": "2019-10-01",
     "subscriptionId": "00000000-0000-0000-0000-000000000000",
-    "$filter": "usagedate ge '2018-04-01' AND usagedate le '2018-04-02'"
+    "$filter": "properties/usagedate ge '2018-04-01' AND properties/usagedate le '2018-04-02'"
   },
   "responses": {
     "200": {

diff --git a/...-manager/Microsoft.Consumption/stable/2019-10-01/examples/ForecastsListFilterByGrain.json b/...-manager/Microsoft.Consumption/stable/2019-10-01/examples/ForecastsListFilterByGrain.json
@@ -2,7 +2,7 @@
   "parameters": {
     "api-version": "2019-10-01",
     "subscriptionId": "00000000-0000-0000-0000-000000000000",
-    "$filter": "Grain eq 'Monthly'"
+    "$filter": "properties/Grain eq 'Monthly'"
   },
   "responses": {
     "200": {