Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defined constructors should reside in the AST module #287

Closed
6 tasks done
andreasabel opened this issue Jan 4, 2020 · 0 comments
Closed
6 tasks done

defined constructors should reside in the AST module #287

andreasabel opened this issue Jan 4, 2020 · 0 comments
Assignees
@andreasabel
Labels
define Issue with define pragma enhancement Java
Milestone
2.9.2

Comments

@andreasabel
Copy link
Member

andreasabel commented Jan 4, 2020 •
edited
Loading

defined constructors should reside in the AST module, rather than just in the parser.

  • Modify the TypeChecker to store the inferred types of the definition arguments.
  • Place the definitions in the AST module (together with their type signatures).
  • Java: cannot place into package Absyn, place in class AbsynDef

Backends:

  • Agda
  • Haskell
  • C
  • C++
  • Java
  • Ocaml
@andreasabel andreasabel added enhancement define Issue with define pragma labels Jan 4, 2020
@andreasabel andreasabel modified the milestone: 2.8.4 Jan 4, 2020
andreasabel added a commit that referenced this issue Jan 18, 2020
@andreasabel
[ #287 ] fixed for Haskell; moved definitions to Abs module
0cc7c33
andreasabel added a commit that referenced this issue Jan 18, 2020
@andreasabel
[ #287 Haskell ] append _ to defs only if conflict with reserved word
a91bd13
andreasabel added a commit that referenced this issue Jan 18, 2020
@andreasabel
[ #287 ] fixed for Agda: generate definitions in AST module
e5c882d
@andreasabel andreasabel self-assigned this Mar 21, 2021
@andreasabel andreasabel added this to the 2.9.2 milestone Mar 21, 2021
andreasabel added a commit that referenced this issue Mar 21, 2021
@andreasabel
[ #287 ocaml ] move defined constructors from Par to Abs
7fcef49
@andreasabel andreasabel removed the C++ label Apr 1, 2021
andreasabel added a commit that referenced this issue Apr 1, 2021
@andreasabel
[ #287 ] fixed for C++: defined constructors now in Absyn module
8984e91
This was referenced Apr 28, 2021
Closed
Closed
andreasabel added a commit that referenced this issue May 18, 2021
@andreasabel
[ #363 #287 ] fixed for Java
fdbac3b 
- do not invoke the type checker a second time
- 'cons' needed in AbsynDef.java
- sanitize Java keywords clashing with definitions
andreasabel added a commit that referenced this issue May 18, 2021
@andreasabel
[ #363 #287 ] fixed for Ocaml: cons, sanitization of keywords
d67f07e
andreasabel added a commit that referenced this issue May 18, 2021
@andreasabel
[ #363 #287 ] fixed for C++: cons, sanitization of keywords
2dbcb9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
define Issue with define pragma enhancement Java
Projects
None yet
Milestone
2.9.2
Development

No branches or pull requests
1 participant
@andreasabel