Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added static field defaultCacheManager to CachedNetworkImageProvider #933

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

AurelVU
Copy link

@AurelVU AurelVU commented Mar 27, 2024

✨ This pull request is aimed at creating the ability to globally configure the default caching manager

⤵️ Currently, if you need to globally override the caching manager, you need to register it in the constructor of each widget. This is extremely inconvenient if the project grows, and also creates risks that the developer may forget to specify it

🆕 The CachedNetworkImageProvider class now has a static field that can be defined before the application starts. It is the value of this field that will be used in the case when the user did not pass any value to the caching manager

💥 This PR does not make global changes

🐛 It is recommended to check the work associated with switching the default cache manager while the application is running

🤔 Pre-shipment checklist

  • [ +] All build projects
  • [ +] Follows style guidelines (code style guide)
  • Relevant documentation has been updated.
  • [+ ] Reworked based on current development

@martijn00 martijn00 force-pushed the develop branch 3 times, most recently from d575a2d to ba3a961 Compare July 31, 2024 17:22
@martijn00 martijn00 merged commit c5c650f into Baseflow:develop Jul 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants