Fix byte length counting if strlen overloading used #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,8 +55,8 @@ public function send() | |||
| // get content to send | |||
| $response = $this->getContent(); | |||
| // set Content-Length header | |||
| header('Content-Length: '. strlen($response)); | |||
| header('Content-Length: ' . mb_strlen($response, '8bit')); | |||
There was a problem hiding this comment.
Please check that mb_strlen() is available before to use or use strlen() function instead: https://github.com/symfony/Validator/blob/v2.3.6/Constraints/LengthValidator.php#L40
|
Updated and squashed the PR. |
ratnayake
added a commit
to ratnayake/BeSimpleSoap
that referenced
this pull request
Oct 3, 2014
Add Basic auth to read from config.yml file you can view example from src\BeSimple\SoapBundle\Resources\doc\soapclient\configuration.rst line BeSimple#18 onwards
data219
pushed a commit
to Preis24/BeSimpleSoap
that referenced
this pull request
Nov 4, 2015
Add Basic auth to read from config.yml file you can view example from src\BeSimple\SoapBundle\Resources\doc\soapclient\configuration.rst line BeSimple#18 onwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function strlen() counts characters instead of bytes if mbstring.func_overload is used in php.ini so Content-Length header gets a wrong value.
I changed strlen() call to mb_strlen() with "8bit" encoding as suggested here http://www.php.net/manual/ru/function.mb-strlen.php#77040
May be we can even get rid of setting Content-Length explicitly?