Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and split 'InstallDependency' #53

Closed
SirLich opened this issue Oct 10, 2021 · 0 comments
Closed

Rename and split 'InstallDependency' #53

SirLich opened this issue Oct 10, 2021 · 0 comments
Assignees
@Nusiq
Labels
technical debt
Milestone
1.x Post Release

Comments

@SirLich
Copy link
Contributor

SirLich commented Oct 10, 2021

Its long, and does two things, I guess.
@SirLich SirLich added this to the 1.x Post Release milestone Oct 10, 2021
Nusiq added a commit that referenced this issue Nov 4, 2021
@Nusiq
Cleaning up the code mostly for issue #53
9b06878 
Changes:
- Removed InstallDependency function. Now it's the Install method of the Profile struct.
- Renamed Filter.GetName method to GetFriendlyName and removed the 'Running filter' message from it
- Cleaning up InstallDependency function spawned a few new methods (they should probably be moved somewhere else in the code). The methods: Filter.GetDownloadUrl, Filter.GetIdName, Filter.Download (all of the new functions/methods have are documented with comments).

This commit doesn't change how the code works (with some small exceptions). Next cleanup step will probably slightly change the logic of the code.
@Nusiq Nusiq closed this as completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nusiq Nusiq

Labels
technical debt
Projects
None yet
Milestone
1.x Post Release
Development

No branches or pull requests
2 participants
@SirLich @Nusiq