Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes electronic paper reader looping infinitely #11531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aramix273
Copy link
Contributor

About The Pull Request

the electronic paper reader currently has a problem with infinite looping
it has some logic that is supposed to split the paper in paragraphs and read out each one separately
however, it does not properly remove the elements from the list it builds
this means it will loop infinitely on the first element until interrupted with a click or by reading a blank paper
testing evidence shows both the bug and the behavior after fixing

PR represents a one-line fix to this problem
to_read.Remove(1) seems to have been used with 1 as an index in semantics
replaced that 1 with a to_read[1] to match the element semantics described in the documentation for the list.Remove() proc

Why It's Good For The Game

this means no more annoying infinite reader spam and having to find workarounds the problem of it infinitely repeating such as by reading a blank paper
PR might not be desirable if the reader is intended to read in an infinite loop

Testing Photographs and Procedure

Screenshots&Videos

before the fix:

readerbug.mp4

after the fix:

readertesting.mp4

testing procedure involved testing with an empty paper (does nothing), then a paper with one paragraph, then one with multiple (such as video above), additionally one with a stamp (doesn't seem to be read out)
interrupting with a click also seems to work when reading out multiple paragraphs

Changelog

🆑 Aramix
fix: fixed the electronic paper reader infinitely reading out the first paragraph in a paper
/:cl:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants