Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rails 7.1 support #12

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Rails 7.1 support #12

wants to merge 4 commits into from

Conversation

argvniyx-enroute
Copy link

@argvniyx-enroute argvniyx-enroute commented Apr 26, 2024 •
edited
Loading

/task https://app.asana.com/0/1205835826533561/1205835897803472/f

@smudge @effron

This adds support for Rails 7.1:

  • Updates the Rails version range in the gemspec
  • Adds an Appraisals entry for 7.1
  • Bumps version.rb
  • bundle install and bundle exec appraisal to generate a new gemfile and update existing ones
  • Adds a Rails 7.1 entry to the gemfile matrix

@argvniyx-enroute argvniyx-enroute marked this pull request as ready for review April 26, 2024 15:52
effron
effron approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@effron effron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM && platformLGTM

@argvniyx-enroute
Copy link
Author

@effron @samandmoore anyone with write powers mind merging this?

@effron
Copy link
Contributor

effron commented May 6, 2024

I don't have write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effron effron effron approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argvniyx-enroute @effron