Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipped axes have empty brushes #60

Open
joshhjacobson opened this issue Jan 12, 2019 · 4 comments
Open

Flipped axes have empty brushes #60

joshhjacobson opened this issue Jan 12, 2019 · 4 comments

Comments

@joshhjacobson
Copy link
Contributor

When an axis is upside down, regardless of whether it was flipped by double-clicking the title or with pc.flipAxes, brushing on that axis causes all polylines to disappear. However, if the axis is flipped back to its normal orientation, brushing works as expected. Interestingly, there is no console error...

Here is a quick screencast to illustrate the issue:
flip_broken

@arif-hanif
Copy link

I have the same issue, is there any resolution

@arif-hanif
Copy link

anyone working on this or should i give it a shot?

@joshhjacobson
Copy link
Contributor Author

@arif-hanif I would be great if you could give it a shot!

@solidchu
Copy link

number: function number(d, p, dimension) {
if (typeof config.dimensions[p].yscale.bandwidth === 'function') {
// if it is ordinal
return extents[dimension][0] <= config.dimensions[p].yscale(d[p]) && config.dimensions[p].yscale(d[p]) <= extents[dimension][1];
} else {
if (extents[dimension][0]>extents[dimension][1])
return extents[dimension][1] <= d[p] && d[p] <= extents[dimension][0];
else
return extents[dimension][0] <= d[p] && d[p] <= extents[dimension][1];
}

I found the problem. When the flip of axes, the extents[dimension][0] and [1] are reversed. So, if you change the code as like above, it is fixed.

abuzreq added a commit to abuzreq/parcoords-es that referenced this issue May 12, 2021
Applying the fix in BigFatDog#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants