Skip to content

Commit

Permalink
Merge pull request #21 from cristijora/issue#20
Browse files Browse the repository at this point in the history
Minor updates on readme and demos [Related on issues #20]
  • Loading branch information
cristijora committed Feb 18, 2018
2 parents a616916 + c32063e commit 4dc60c9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Why use it?
- [Overlaping notifications](https://jsfiddle.net/z11fe07p/2878/)
- [Custom html content via components](https://jsfiddle.net/z11fe07p/2880/)
- [Custom animations](https://jsfiddle.net/z11fe07p/2882/)
- [Close all notifications](https://jsfiddle.net/z11fe07p/2883/)
- [Clears all current notifications](https://jsfiddle.net/z11fe07p/2883/)

### 3 themes supported
#### [Default theme](https://jsfiddle.net/z11fe07p/2879/)
Expand Down
2 changes: 1 addition & 1 deletion example/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<button class="btn btn-default btn-block" @click="addNotificationNoCloseOnClick()">No close on click</button>
<button class="btn btn-default btn-block" @click="addNotificationNoCloseIcon()">No close icon</button>
<button class="btn btn-default btn-block" @click="addNotificationWithClickHandler()">With click handler</button>
<button class="btn btn-default btn-block" @click="removeNotifications">Clear all notifications</button>
<button class="btn btn-default btn-block" @click="removeNotifications()">Clear all notifications</button>
</div>
</template>
<script>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vue-notifyjs",
"version": "0.4.1",
"version": "0.4.2",
"description": "Simple notification component for Vue.js",
"repository": {
"url": "cristijora/vue-notifyjs",
Expand Down
3 changes: 1 addition & 2 deletions src/Notification.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export default {
},
methods: {
close () {

this.$emit('close', this.timestamp)
},
tryClose (evt) {
Expand Down Expand Up @@ -125,7 +124,7 @@ export default {
this.icon && <span data-notify="icon" class={['alert-icon', this.icon]}></span>
}
<span data-notify="message">
{this.title !== undefined && <span class="title"><b>{this.title}<br/></b></span>}
{this.title !== undefined && <span class="title"><b>{this.title}<br/></b></span>}
{this.message !== undefined && this.message}
{this.component !== undefined &&
<this.component></this.component>}
Expand Down

0 comments on commit 4dc60c9

Please sign in to comment.