Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remap old config variables #1509
Remap old config variables #1509
Changes from 3 commits
297ce40
8c9e5f0
fdae670
40d4e40
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming this is an intended change in logic. The proposed code will default to using the upload_temp_directory returned by ini_get('upload_tmp_dir') unless that function returns false. The previous logic appears to default to the value in $GLOBALS["tempDirRoot"] . Perhaps the intent is to default to the new $GLOBALS["TEMP_DIR_ROOT"] and fallback to ini_get('upload_tmp_dir') if that global is empty ? (line 446 will short-circuit on !$Path )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, defaulting to upload_tmp_dir is the attended action. The old code defaulted to using the old variable format (tempDirRoot), and then upload_tmp_dir, and then the new format (TEMP_DIR_ROOT), which is a little screwy. Simply defaulting to upload_tmp_dir, and then TEMP_DIR_ROOT, is perfect. Thanks for checking.