Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-ux): remove bittrex from exchange list #4148

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

fullstackninja864
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

Copy link
Contributor

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}

Copy link
Contributor

Build preview for DeFiChain Wallet is ready!

Built with commit 4d06945

https://expo.io/@defichain/wallet?release-channel=pr-preview-4148

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0d2511) 53.70% compared to head (c2a3d41) 61.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4148      +/-   ##
==========================================
+ Coverage   53.70%   61.52%   +7.81%     
==========================================
  Files         438      438              
  Lines       12445    12445              
  Branches     4122     4122              
==========================================
+ Hits         6684     7657     +973     
+ Misses       5680     4696     -984     
- Partials       81       92      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierregee pierregee merged commit 065f4e6 into main Nov 28, 2023
15 of 16 checks passed
@pierregee pierregee deleted the harsh/remove-bittrex branch November 28, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants