Cardano: Update and regenerate protobuffs #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RostarMarek
force-pushed
the
rostarmarek/cardano-vote-deleg
branch
2 times, most recently
from
a120086
to
4e23503
Compare
RostarMarek
force-pushed
the
rostarmarek/cardano-vote-deleg
branch
from
4e23503
to
3f04a0f
Compare
benma
requested changes
Sep 23, 2024
tests/subtests/test_cardano.rs
Outdated
| allow_zero_ttl: false, | ||
| }; | ||
|
|
||
| let witness = bitbox.cardano_sign_transaction(transaction).await.unwrap(); |
There was a problem hiding this comment.
I think you'll need to check for success if the firmware version is >= 9.21.0, and for failure otherwise, as older firmwares don't yet have support for vote delegation.
benma
requested changes
Sep 23, 2024
RostarMarek
force-pushed
the
rostarmarek/cardano-vote-deleg
branch
2 times, most recently
from
b365ed6
to
cb6bee3
Compare
benma
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Thanks. CI fails b/c it seems rustfmt didn't format the code:
Diff in /home/runner/work/bitbox-api-rs/bitbox-api-rs/tests/subtests/test_cardano.rs:207:
allow_zero_ttl: false,
};
- if semver::VersionReq::parse(">=9.21.0").unwrap().matches(bitbox.version()) {
+ if semver::VersionReq::parse(">=9.21.0")
+ .unwrap()
+ .matches(bitbox.version())
+ {
let witness = bitbox.cardano_sign_transaction(transaction).await.unwrap();
assert_eq!(witness.shelley_witnesses.len(), 2);
assert_eq!(
Error: Process completed with exit code 1.
Update and regenerate protobuffs to allow vote delegation on cardano
RostarMarek
force-pushed
the
rostarmarek/cardano-vote-deleg
branch
from
cb6bee3
to
6ecf013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update and regenerate protobuffs to allow vote delegation on cardano.