Base path is lost when replacing path params

[nicob21]

When path params get replaces, we loose any base path that was set in the base url.

https://github.com/BitGo/api-ts/blob/master/packages/superagent-wrapper/src/request.ts#L79-L90

For example, if the base is http://localhost/foo and the route path is /bar
The url pathname contains /foo at the beginning and after replacing the params in /foo the /bar part is lost.

That means that if all our endpoints have a common base param we can pass it in the base URL and we need to add it to every route.

Could we just concatenate the result of substitutePathParams to url.pathname instead of replacing it?

[github-actions]

🎉 This issue has been resolved in version @api-ts/express-wrapper@1.0.12 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version @api-ts/superagent-wrapper@1.1.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version @api-ts/typed-express-router@1.0.9 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[adrian-gierakowski]

Thanks!

[github-actions]

🎉 This issue has been resolved in version @api-ts/io-ts-http@2.1.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version @api-ts/response@2.0.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version @api-ts/openapi-generator@1.0.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀