fix(superagent-wrapper): support non-/
api base paths
#380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #337. I initially tried to use an alternate URL constructor like:
and was surprised to learn that this actually has the exact same behavior of stripping the base path. It seems like it should be possible to make the substituted path a relative one, but that has issues as well.
Ultimately I pulled in
posix.join
frompath
. This works, but may potentially introduce issues with some web bundlers if they don't provide an implementation of Node'spath
module.