Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: add type error if path doesn't start with /" #901

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Revert "feat: add type error if path doesn't start with /" #901

merged 1 commit into from
Sep 13, 2024

Conversation

bitgopatmcl
Copy link
Contributor

Causes type errors when multiple copies of io-ts-http 3.x are in node_modules, which is unfortunately easy to do.

Fixes:

Types of property 'path' are incompatible.
                Type 'string' is not assignable to type '`/${string}`'.

This reverts commit a27e388.

@bitgopatmcl bitgopatmcl requested a review from a team as a code owner September 13, 2024 15:47
@bitgopatmcl bitgopatmcl marked this pull request as draft September 13, 2024 15:47
@bitgopatmcl bitgopatmcl marked this pull request as ready for review September 13, 2024 15:47
ericcrosson-bitgo
ericcrosson-bitgo approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a commit we should ship in a v4 then?

@bitgopatmcl bitgopatmcl merged commit f1f80af into master Sep 13, 2024
6 checks passed
@bitgopatmcl bitgopatmcl deleted the revert-leading-slash-type-change branch September 13, 2024 20:10
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@1.1.11 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/io-ts-http@3.2.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/superagent-wrapper@1.3.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@1.0.31 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcrosson-bitgo ericcrosson-bitgo ericcrosson-bitgo approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitgopatmcl @ericcrosson-bitgo