Remove usage of "-DISABLE_OPENACC" for artificial cells #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See neuronsimulator/nrn/pull/2653 for details/motivation
iomaganaris
approved these changes
Jan 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1133 +/- ##
==========================================
+ Coverage 88.21% 88.32% +0.11%
==========================================
Files 175 175
Lines 13024 12980 -44
==========================================
- Hits 11489 11465 -24
+ Misses 1535 1515 -20 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #188719 (:white_check_mark:) have been uploaded here! Status and direct links: |
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Jan 27, 2024
* Remove usage of -DDISABLE_OPENACC (GPU build simplification) - always use Random123 via unified memory support - some of the cpp files were avoided it via `-DDISABLE_OPENACC` but with the addition of RANDOM construct, the Random123 streams are allocated during model setup. So it's better to do this in one way unless there is performance degradation. * update nmodl as well : BlueBrain/nmodl/pull/1133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See neuronsimulator/nrn/pull/2653 for details/motivation