Newton error propagation based convergence check. #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1403 +/- ##
==========================================
- Coverage 86.56% 86.54% -0.03%
==========================================
Files 182 182
Lines 13549 13559 +10
==========================================
+ Hits 11729 11734 +5
- Misses 1820 1825 +5 ☔ View full report in Codecov by Sentry. |
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 19, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 23, 2024
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 26, 2024
This comment has been minimized.
This comment has been minimized.
JCGoran
reviewed
Aug 29, 2024
Instead of `(X - X_old) = dt * dX`. The implemented scaling is the one implemented in NOCMODL. It should prevent the residual from growing linearly with `dt`.
Includes a test that solves the pump equation
~ X + Y <-> Z
with extreme compartment sizes and steady state calculation.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 29, 2024
|
Logfiles from GitLab pipeline #228874 (:white_check_mark:) have been uploaded here! Status and direct links: |
1uc
added a commit
that referenced
this pull request
Aug 30, 2024
1uc
added a commit
that referenced
this pull request
Sep 2, 2024
1uc
added a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have access to the Jacobian, we can use Newton error propagation:
with
sd = eps * Xto estimate the impact of roundoff errors onF.