Change dependency handling #61
Conversation
docs/source/installation.rst
Outdated
| ``rabbitmq`` Installs the required dependencies for using Dramatiq with RabbitMQ. | ||
| ``redis`` Installs the required dependencies for using Dramatiq with Redis. | ||
| ``watch`` Installs the required dependencies for the ``--watch`` flag. | ||
| ``prometheus`` Installs the required dependencies for the Prometheus statistics middleware. |
There was a problem hiding this comment.
Prometheus can't be an optional dependency right now because it's a default middleware
There was a problem hiding this comment.
Should prometheus be made non-default, or should this change be reverted? As a user, the former would be preferable since we don't use prometheus.
There was a problem hiding this comment.
Although I understand if you'd rather make that change later.
There was a problem hiding this comment.
That's a change I'm planning for the next major release since it's a breaking change. It'll take a while to come out, though, because I'd like to avoid churning major version releases quickly.
|
My intention with the default extras was for |
Cursory glance at this issue indicates this is not a feature. |
|
That's unfortunate. I just checked the Dramatiq docs briefly and it looks like we always recommend installing w/ explicit extras so this looks good to me! I'll merge it tonight along w/ the other PR. I expect I'll do a 1.1 release sometime next week. |
Should fix #60