case schema enhancements (#82)

* case schema enhancements

lib/validation-helpers/schemas.js

@@ -84,16 +84,17 @@ const caseSchema = joi.object().keys({
   namespace: requiredString.valid(...salesforceCaseNamespaces),
   businessType: joi.string().valid("BN_B2C", "BN_B2B"),
   category: joi.string(),
-  contact: joi.object().keys({
+  contact: joi.alternatives(joi.object().keys({
     firstName: joi.string(),
     lastName: joi.string(),
     email: requiredString,
     phone: joi.string().regex(/^[+\d][0-9]{7,14}$/),
     customerNumber: joi.string(),
-  }).optional(),
+  }), joi.object().keys({ id: requiredString })).optional(),
   deploymentName: joi.string(),
   description: requiredString,
   externalReference: joi.string().optional(),
+  eTaskId: joi.string().optional(),
   origin: requiredString,
   owner: requiredString,
   priority: joi.string().optional().valid("High", "Medium", "Low"),

package.json

@@ -1,6 +1,6 @@
 {
   "name": "lu-common",
-  "version": "3.8.0",
+  "version": "3.8.1",
   "description": "",
   "main": "index.js",
   "engines": {

test/unit/utils/case-body-helper-test.js

@@ -49,12 +49,32 @@ describe("create back office case body", () => {
     });
   });
 
+  describe("when calling the create body with a contact with email", () => {
+    it("should create the expected body with sent in parameters", () => {
+      const contact = { firstName: "Joe", lastName: "Bloggs", email: "some@example.com" };
+      createBackOfficeCaseBody(subject, description, namespace, { contact }).should.eql({
+        ...backOfficeCaseBody,
+        contact,
+      });
+    });
+  });
+
+  describe("when calling the create body with a contact id", () => {
+    it("should create the expected body with sent in parameters", () => {
+      const contact = { id: "some-id" };
+      createBackOfficeCaseBody(subject, description, namespace, { contact }).should.eql({
+        ...backOfficeCaseBody,
+        contact,
+      });
+    });
+  });
+
   describe("when calling the create body with a badly formed contact", () => {
     it("should fail the joi validation", () => {
       try {
         createBackOfficeCaseBody(subject, description, namespace, { contact: { firstName: "Joe", lastName: "Bloggs" } });
       } catch (error) {
-        error.message.should.eql('"contact.email" is required');
+        error.message.should.eql('"contact" does not match any of the allowed types');
       }
     });
   });