Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always default to proxyUrl if awsProxyUrl isn't set #90

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Always default to proxyUrl if awsProxyUrl isn't set #90

merged 1 commit into from
Sep 28, 2023

Conversation

BN-CRehn
Copy link
Contributor

Checklist

  • Was the code tested in lab?
  • Have you reviewed the code yourself?
  • Are the configs updated?
  • Does the readme need an update?

Write the description and the reason for this PR below ↓

Makes it possible to not have to set a config variable called awsProxyUrl, and if not then
default to proxyUrl

@BN-CRehn BN-CRehn requested a review from a team as a code owner September 28, 2023 13:12
johark
johark approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@johark johark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@BN-CRehn BN-CRehn merged commit 34a933d into master Sep 28, 2023
2 checks passed
@BN-CRehn BN-CRehn deleted the feature/default-proxy-url branch September 28, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johark johark johark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BN-CRehn @johark