Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregates address #166

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Aggregates address #166

merged 2 commits into from
Mar 9, 2021

Conversation

Burgyn
Copy link
Owner

@Burgyn Burgyn commented Mar 9, 2021

There is no need to make HTTP call to yourself in case of Gateway it self or Aggregates route. We will use ISwaggerProvider for that.

@update-docs
Copy link

update-docs bot commented Mar 9, 2021

Thanks for opening this pull request! If you have implemented new functions, write about them in the readme file.

@Burgyn Burgyn merged commit 85ab68a into master Mar 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the aggregates-address branch March 9, 2021 07:06
@samuelpratt
Copy link

Thanks :-) This seems to fix the issue. However, when testing I did notice something else:

When testing I upgraded all my Nuget packages.

When I upgrade Swashbuckle to v6.0.1 it introduces another error. It would appear that the maintainers of this package changed the interface to Swashbuckle.AspNetCore.SwaggerGen.SchemaRepository in v.6.0.1. This produces the following error: -

System.MissingMethodException HResult=0x80131513 Message=Method not found: 'Void Swashbuckle.AspNetCore.SwaggerGen.SchemaRepository..ctor()'. Source=MMLib.SwaggerForOcelot StackTrace: at MMLib.SwaggerForOcelot.Aggregates.AggregateRouteDocumentationGenerator..ctor(IOptions1 routes, IRoutesDocumentationProvider routesDocumentationProvider, IDefinedAggregatorProvider definedAggregatorProvider, Action4 postProcess, ISchemaGenerator schemaGenerator) at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)

However, it looks like the project maintainers have realised this and are fixing it in 6.0.2: domaindrivendev/Swashbuckle.AspNetCore@4331154

Do you want me to raise this as another issue or ignore it as it appears to be something that's going to go away of it's own accourd in Swashbuckly 6.0.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants