Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure quoted keys with dots work well #333

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Make sure quoted keys with dots work well #333

merged 1 commit into from
Nov 25, 2021

Conversation

arp242
Copy link
Collaborator

@arp242 arp242 commented Nov 25, 2021

Using strings.Join(key, ".") is problematic as these:

"foo.bar" = 42
foo.bar = 42

Will have the same string value, but are not identical!

Always use maybeQuotedAll() in String(); I don't know when you would
ever not want to use quoting.

Using strings.Join(key, ".") is problematic as these:

  "foo.bar" = 42
  foo.bar   = 42

Will have the same string value, but are not identical!

Always use maybeQuotedAll() in String(); I don't know when you would
ever *not* want to use quoting.
@arp242 arp242 merged commit 7d0236f into master Nov 25, 2021
@arp242 arp242 deleted the qk branch November 25, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant