-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
버그가 발견되어 잠시 닫을게요 고치고 리오픈하겠습니다 😢 |
@@ -303,7 +304,11 @@ private void closeWithThrowingAnimation(Point targetPoint) { | |||
mFloatingTab.closeAnimation(targetPoint, new Runnable() { | |||
@Override | |||
public void run() { | |||
activateDragger(); | |||
try { | |||
activateDragger(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josh-yun 일반적인 상황에서는 발생하지 않을 것 같아서 try catch 로 잡아봤습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@realwind2048 activateDragger() 함수에서 null check 를 하는 방식은 이상할까요? State가 가지고 있는 mHoverView의 경우 null 일 경우도 있는 것 같아요. (Ex. State 전환) 만약 null check 방식으로 바뀔 경우, activate에 실패하면 앱이 죽는 대신 클릭이 안되는 상황이 발생할텐데... 어떤 것이 더 critical 할 지는 잘 모르겠지만, Pop을 끄는 상황에서는 다른점이 없어보이네요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try catch 보다 그 쪽이 명확할 것 같아서 반영했습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 4f49a5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
에니메이션이 들어가니 좀 복잡해지긴 하네요 LGTM:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
팝을 Throw 해서 종료 애니메이션 중에, showPop을 할 경우 팝아이콘이 사라지는 문제를 수정