Skip to content

Commit

Permalink
Fix sound selection persisting after switching categories in the Soun…
Browse files Browse the repository at this point in the history
…d Glossary
  • Loading branch information
krypciak committed May 13, 2024
1 parent 9b79580 commit 63004a4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- Fixed unnamed NPC names being announced as MISSING LABEL
- Fixed aim analysis hint selection persisting when entering the quick menu
- Fixed hint selecting persisting after the upgrade field in Rhombus Dungeon was used
- Fixed sound selection persisting after switching categories in the Sound Glossary

## [0.6.0] 2024-04-20

Expand Down
5 changes: 3 additions & 2 deletions src/manuals/hud/sound-glossary.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ export class SoundGlossary {
},
onLeftRightPress() {
sc.BUTTON_SOUND.submit.play()
menu.stopSound()
return { skipSounds: true }
},
onContentCreation(index, settings) {
Expand Down Expand Up @@ -276,8 +277,6 @@ export class SoundGlossary {
},
hideMenu() {
this.parent()
this.isEntrySelected = false
this.currentSelectedButton?.keepButtonPressed(false)
this.stopSound()
SpecialAction.setListener('LSP', 'soundglossary', () => {})
},
Expand Down Expand Up @@ -308,6 +307,8 @@ export class SoundGlossary {
this.isSoundOn = true
},
stopSound() {
this.isEntrySelected = false
this.currentSelectedButton?.keepButtonPressed(false)
this.isSoundOn = false
const entry = this.currentSelectedButton?.entry
if (!entry) return
Expand Down

0 comments on commit 63004a4

Please sign in to comment.